Skip to content

Conversation

@freaknils
Copy link
Contributor

Added more parameters for check_smart_attributes.

@cla-bot

This comment was marked as outdated.

Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, thanks a lot for your contribution!

Please sign the CLA as the bot indicated and comment here that you did so. Afterwards, we can proceed with your PR.

I have added a few single comments for improvements. Please address them as you see fit.

Since I am not familiar with the check_smart_attributes check, I could only perform a "vibe check" and compare your changes against the Perl code upstream. It seems you have added all options from the current master, thanks.

One task left would be to list the new options in the documentation. Please update the table in the the ./doc/10-icinga-template-library.md file.

#### smart-attributes <a id="plugin-contrib-command-smart-attributes"></a>
The [check_smart_attributes](https://github.com/thomas-krenn/check_smart_attributes) plugin
uses the `smartctl` binary to monitor SMART values of SSDs and HDDs.
Custom variables passed as [command parameters](03-monitoring-basics.md#command-passing-parameters):
Name | Description
--------------------------------|-----------------------------------------------------------------------
smart_attributes_config_path | **Required.** Path to the smart attributes config file (e.g. check_smartdb.json).
smart_attributes_device | **Required.** Device name (e.g. /dev/sda) to monitor.

@oxzi oxzi added the area/itl Template Library CheckCommands label Sep 24, 2025
@cla-bot
Copy link

cla-bot bot commented Oct 6, 2025

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @freaknils

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@freaknils
Copy link
Contributor Author

CLA is now verified

@bobapple
Copy link
Member

bobapple commented Oct 6, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Oct 6, 2025
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. In general, LGTM.

Please also add yourself to the AUTHORS file:

--- a/AUTHORS
+++ b/AUTHORS
@@ -203,6 +203,7 @@ Nicolas Limage <[email protected]>
 Nicolas Rodriguez <[email protected]>
 Nicole Lang <[email protected]>
 Niflou <[email protected]>
+Nils Czernia <[email protected]>
 Noah Hilverling <[email protected]>
 Obihörnchen <[email protected]>
 Oleg Artenii <[email protected]>

Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

@oxzi oxzi merged commit beddc3f into Icinga:master Oct 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/itl Template Library CheckCommands cla/signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants