Add tooltips for state pictograms #1262
Conversation
| : sprintf($this->translate('Host "%s" is unreachable'), $item->display_name); | ||
|
|
||
| $statusIcons->addHtml(new Icon('random', ['title' => $title])); | ||
| $statusIcons->add(new Icon(Icons::HOST_DOWN, ['title' => $title])); |
There was a problem hiding this comment.
Please use addHtml.
| const IS_ACKNOWLEDGED = 'check'; | ||
|
|
||
| const IS_FLAPPING = 'bolt'; | ||
| const IS_FLAPPING = 'random'; |
There was a problem hiding this comment.
Why did you change the icon? If this was not discussed, please remove this change.
There was a problem hiding this comment.
If the reason is that the footer used it, then it was wrong to use random before. The state-ball visuals have always used bolt.
There was a problem hiding this comment.
This was discussed with @lippserd. I think the reason was to have the state-ball and footer visual the same.
There was a problem hiding this comment.
This will be a breaking change. There must be a reason why we used bolt before. @flourish86, can you please clarify which icon should be used here?
There was a problem hiding this comment.
Interesting and great that this is pointed out.
It doesn't make sense to have two different icons for flapping. We added the flapping "bolt" to the state ball after the footer icon and probably haven't though of to adjust the latter.
Looking at it after taking a step back, the footer icon doesn't deliver any value anymore, so my suggestion would be to drop it completely and continue to use the bolt icon for the state ball.
There was a problem hiding this comment.
The footer should also have the icon (it is part of .state-icons in detailed view mode, which can show more icons at the same time as the state-ball), but the same as state-ball, so we’ll use the bolt icon.
There was a problem hiding this comment.
he footer icon doesn't deliver any value anymore
It still delivers value, as the host can be in downtime and in flapping state at the same time, but the state-ball will only show downtime icon.
There was a problem hiding this comment.
The footer should also have the icon (it is part of
.state-iconsindetailedview mode, which can show more icons at the same time as the state-ball), but the same asstate-ball, so we’ll use thebolticon.
Yes, I know the icons in the footer. But removing only the flapping icon would not harm the others, would it?
It still delivers value, as the host can be
in downtimeand inflappingstate at the same time, but the state-ball will only showdowntimeicon.
Ok, I’d consider this quite an edge case and I’d argue, that if it actually is in downtime most people will not care about the object flapping.
I'm fine with keeping it, though.
Besides that, the icons have to be the same. So one of those has to be changed. I’d opt for the one in the footer, since the bolt works better with larger sizes in the state ball. And the event visuals for flapping also use the bolt icon.
|
And please rebase. |
Refs #1043
Resolves #819