Add links to tactical overview headers #1263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
feature/tactical-header-links
branch
from
e94b736 to
24e485f
Compare
flourish86
requested changes
Aug 6, 2025
Contributor
flourish86
left a comment
flourish86
left a comment
There was a problem hiding this comment.
lgtm so far.
We also discussed the hover effect for the donut label. Are you going to add that as well?
flourish86
previously approved these changes
Aug 6, 2025
Contributor
flourish86
left a comment
flourish86
left a comment
There was a problem hiding this comment.
Haha, found it. icingaweb2/#5400
Contributor
Author
Sorry, could have written it here. 😅 |
nilmerg
requested changes
Oct 15, 2025
| new HtmlElement( | ||
| 'span', | ||
| Attributes::create(['class' => 'meta']), | ||
| new HtmlElement('span', null, new Text('Total ')), |
Member
There was a problem hiding this comment.
This was translated prior to this!
| new HtmlElement( | ||
| 'span', | ||
| Attributes::create(['class' => 'meta']), | ||
| new HtmlElement('span', null, new Text('Total ')), |
Add an action link on the total hosts number that opens the list that the host donut chart in the tactical overview represents considering the active filters.
Add an action link on the total services number that opens the list that the service donut chart in the tactical overview represents considering the active filters.
jrauh01
force-pushed
the
feature/tactical-header-links
branch
from
24e485f to
6b6e15e
Compare
Contributor
The blue numbers don’t fit here. The What do you suggest @flourish86? I suggest using a style similar to what the 
Suggestion:
On Hover: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add links on the tactical overview chart headers that open the lists that the donut charts represents considering the active filters.
Closes #820