Add more state pictograms #1271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now also add pictograms to state ball in the following cases: - Disabled active checks - Disabled notifications
jrauh01
force-pushed
the
feature/more-state-pictograms
branch
from
7d04cb3 to
4c6da51
Compare
sukhwinder33445
requested changes
Nov 6, 2025
Comment on lines
+344
to
+350
| if ($icon === null) { | ||
| if (! $item->notifications_enabled) { | ||
| $icon = new Icon(Icons::NO_NOTIFICATIONS, ['title' => $this->translate('Notifications disabled')]); | ||
| } elseif (! $item->active_checks_enabled) { | ||
| $icon = new Icon(Icons::NO_ACTIVE_CHECKS, ['title' => $this->translate('Active checks disabled')]); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
These icons are still missing in the specific column view list (e.g., URL: icingadb/hosts?columns=name). These should be added to the State::getIcon() method to cover all use cases.
| if (! $item->active_checks_enabled) { | ||
| $statusIcons->addHtml( | ||
| new Icon('eye-slash', ['title' => $this->translate('Active checks disabled')]) | ||
| new Icon(Icons::NO_ACTIVE_CHECKS, ['title' => $this->translate('Active checks disabled')]) |
Contributor
There was a problem hiding this comment.
To be consistent with other icons in the footer and improve accessibility, please add Host/service '%s' has active checks disabled.
| if (! $item->notifications_enabled) { | ||
| $statusIcons->addHtml( | ||
| new Icon('bell-slash', ['title' => $this->translate('Notifications disabled')]) | ||
| new Icon(Icons::NO_NOTIFICATIONS, ['title' => $this->translate('Notifications disabled')]) |
Contributor
There was a problem hiding this comment.
To be consistent with other icons in the footer and improve accessibility, please add Host/service '%s' has notifications disabled.
Comment on lines
+25
to
+27
| const NO_NOTIFICATIONS = 'bell-slash'; | ||
|
|
||
| const NO_ACTIVE_CHECKS = 'eye-slash'; |
Contributor
There was a problem hiding this comment.
I suggest using NOTIFICATIONS_DISABLED | ACTIVE_CHECKS_DISABLED, as it fits better and describes the variable more clearly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now also add pictograms to state ball in the following cases:
If both active checks and notifications are disabled, the “notifications disabled” icon is shown. This is because results may still arrive from passive checks, but they cannot trigger notifications when notifications are disabled.
Resolves #1097