Skip to content

Conversation

@nilmerg
Copy link
Member

@nilmerg nilmerg commented Mar 21, 2024

No description provided.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Mar 21, 2024
@nilmerg
Copy link
Member Author

nilmerg commented Mar 21, 2024

@raviks789 I remember that we found an issue which we didn't fix at the time this got introduced. I found this test in my stash. Is this nonsense or do you see what this is supposed to test?

@raviks789
Copy link
Contributor

raviks789 commented Mar 21, 2024

@raviks789 I remember that we found an issue which we didn't fix at the time this got introduced. I found this test in my stash. Is this nonsense or do you see what this is supposed to test?

If I remember correctly, the case was if a navigation item already exists in icingadb-host-action but is not a shared item and the same navigation item is present in host-action as shared item, then only the filter needs to be transformed, instead of creating a new shared navigation item for icingadb-host-action. If I am understanding correctly the test is written for this case.

So I think this is a valid test case if the bug gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants