Merged
Conversation
## Type of Change - [ ] 🚀 New feature (non-breaking change which adds functionality) - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] 🧹 Chore (technical task, refactoring, maintenance) ## Description Briefly describe the changes made in this Pull Request. Explain the solution and the reasoning. This PR fixes `Internal Server Error`s occurring on the `/api/answers/completed/.../affinity/` endpoints. The errors were caused by explicitly null JSON values for margin inputs crashing Pydantic validations during compatibility calculations. The changes gracefully fallback to `0` when encountering these cases during `_map_axes`. ## Related Issue Closes # ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. - [x] Unit Tests - [x] Manual Testing ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes ## Screenshots (if applicable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Briefly describe the changes made in this Pull Request. Explain the solution and the reasoning.
This PR fixes
Internal Server Errors occurring on the/api/answers/completed/.../affinity/endpoints.The errors were caused by explicitly null JSON values for margin inputs crashing Pydantic validations during compatibility calculations. The changes gracefully fallback to
0when encountering these cases during_map_axes.Related Issue
Closes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Screenshots (if applicable)
Type of Change
Description
Briefly describe the changes made in this Pull Request. Explain the solution and the reasoning.
Related Issue
Closes # (Link the issue here, e.g., #123)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Screenshots (if applicable)