refactor(*): switch to control flow blocks #14864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecreate for cycle.
Resolve control flow warnings in grid and tree grid.
ChronosSF
previously approved these changes
Feb 25, 2025
ChronosSF
approved these changes
Feb 26, 2025
kdinev
reviewed
Feb 26, 2025
| <igx-column *ngFor="let c of columns" [sortable]="true" [field]="c.field" [header]="c.field" | ||
| [width]="c.width" [pinned]='c.pinned' [hidden]='c.hidden'> | ||
| </igx-column> | ||
| @for (c of columns; track c) { |
There was a problem hiding this comment.
Suggested change
| @for (c of columns; track c) { | |
| @for (c of columns; track c.field) { |
| <igx-column *ngFor="let c of columns" [sortable]="true" [field]="c.field" [header]="c.field" | ||
| [width]="c.width" [pinned]='c.pinned' [hidden]='c.hidden'> | ||
| </igx-column> | ||
| @for (c of columns; track c) { |
There was a problem hiding this comment.
Suggested change
| @for (c of columns; track c) { | |
| @for (c of columns; track c.field) { |
| <igx-column *ngFor="let c of columns" [sortable]="true" [field]="c.field" [header]="c.field" | ||
| [width]="c.width" [pinned]='c.pinned' [hidden]='c.hidden'> | ||
| </igx-column> | ||
| @for (c of columns; track c) { |
There was a problem hiding this comment.
Suggested change
| @for (c of columns; track c) { | |
| @for (c of columns; track c.field) { |
| <igx-column *ngFor="let c of columns" [sortable]="true" [field]="c.field" [header]="c.field" | ||
| [width]="c.width" [pinned]='c.pinned' [hidden]='c.hidden'> | ||
| </igx-column> | ||
| @for (c of columns; track c) { |
There was a problem hiding this comment.
Suggested change
| @for (c of columns; track c) { | |
| @for (c of columns; track c.field) { |
| <igx-column *ngFor="let c of columns" [sortable]="true" [field]="c.field" [header]="c.field" | ||
| [width]="c.width" [pinned]='c.pinned' [hidden]='c.hidden'> | ||
| </igx-column> | ||
| @for (c of columns; track c) { |
There was a problem hiding this comment.
Suggested change
| @for (c of columns; track c) { | |
| @for (c of columns; track c.field) { |
| <igx-column *ngFor="let c of columns" [sortable]="true" [field]="c.field" [header]="c.field" | ||
| [width]="c.width" [pinned]='c.pinned' [hidden]='c.hidden'> | ||
| </igx-column> | ||
| @for (c of columns; track c) { |
There was a problem hiding this comment.
Suggested change
| @for (c of columns; track c) { | |
| @for (c of columns; track c.field) { |
| <igx-column *ngFor="let c of columns" [sortable]="true" [field]="c.field" [header]="c.field" | ||
| [width]="c.width" [pinned]='c.pinned' [hidden]='c.hidden'> | ||
| </igx-column> | ||
| @for (c of columns; track c) { |
There was a problem hiding this comment.
Suggested change
| @for (c of columns; track c) { | |
| @for (c of columns; track c.field) { |
| @@ -585,10 +584,12 @@ class ButtonGroupWithSelectedButtonComponent { | |||
| @Component({ | |||
| template: ` | |||
| <igx-buttongroup> | |||
| <button igxButton *ngFor="let item of items" [selected]="item.key === selectedValue">{{item.value}}</button> | |||
| @for (item of items; track item) { | |||
There was a problem hiding this comment.
Suggested change
| @for (item of items; track item) { | |
| @for (item of items; track item.key) { |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15333
Some changes are manual since the migration didn't detect all uses. Also note that I've manually adjusted the default formatting the ng migration does (worse if it doesn't format), but that was far from error-free and I've corrected the more egregious mishaps or redundant changes. Not perfect yet and will be looking into a formatting tool to enforce since the default VS Code formatting doesn't handle these yet microsoft/vscode-html-languageservice#177.
Also there are an alarming number of warnings for the
trackhandling that's migrated 1:1 from the old behavior, so there's extra reporting now and we should invest some time to track these down.Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)