Skip to content

feat(hierarchical-grid): add parentRowData to IGridCreatedEventArgs #15658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025
Merged

feat(hierarchical-grid): add parentRowData to IGridCreatedEventArgs #15658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d38f068
feat(hierarchical-grid): add parentRowData to IGridCreatedEventArgs
viktorkombov Apr 2, 2025
ed21033
chore(*): Always include parentRowData in the arguments
viktorkombov Apr 4, 2025
785b4e2
chore(*): clean up leftover
viktorkombov Apr 4, 2025
d7d8deb
Merge branch 'master' into vkombov/add-parentRowData-to-IgxGridCreate…
hanastasov Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/igniteui-angular/src/lib/grids/hierarchical-grid/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ export interface IGridCreatedEventArgs extends IBaseEventArgs {
owner: IgxRowIslandComponent;
parentID: any;
grid: IgxHierarchicalGridComponent;
parentRowData?: any;
}
6 changes: 4 additions & 2 deletions projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ export class IgxChildGridRowComponent implements AfterViewInit, OnInit {
this.layout.gridCreated.emit({
owner: this.layout,
parentID: this.data.rowID,
grid: this.hGrid
grid: this.hGrid,
parentRowData: this.data.parentRowData,
});
}

Expand All @@ -231,7 +232,8 @@ export class IgxChildGridRowComponent implements AfterViewInit, OnInit {
this.layout.gridInitialized.emit({
owner: this.layout,
parentID: this.data.rowID,
grid: this.hGrid
grid: this.hGrid,
parentRowData: this.data.parentRowData,
});

this.hGrid.cdr.detectChanges();
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class IgxGridHierarchicalPipe implements PipeTransform {
childGridsData[childKey] = childData;
});
if (grid.gridAPI.get_row_expansion_state(v)) {
result.push({ rowID: primaryKey ? v[primaryKey] : v, childGridsData });
result.push({ rowID: primaryKey ? v[primaryKey] : v, childGridsData, parentRowData: v });
}
});
return result;
Expand Down
16 changes: 16 additions & 0 deletions projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,6 +1119,22 @@ describe('Basic IgxHierarchicalGrid #hGrid', () => {
expect(getterSpy).toHaveBeenCalledTimes(7);
expect(summaryCell.textContent.trim()).toEqual('');
}));

it('should verify gridCreated and gridInitialized events emit correct parentRowData', () => {
const row = hierarchicalGrid.gridAPI.get_row_by_index(0) as IgxHierarchicalRowComponent;
const rowIsland = fixture.componentInstance.rowIsland1;

spyOn(rowIsland.gridCreated, 'emit').and.callThrough();
spyOn(rowIsland.gridInitialized, 'emit').and.callThrough();

UIInteractions.simulateClickAndSelectEvent(row.expander);
fixture.detectChanges();

expect(rowIsland.gridCreated.emit).toHaveBeenCalledTimes(1);
expect(rowIsland.gridCreated.emit).toHaveBeenCalledWith(jasmine.objectContaining({ parentRowData: row.data }));
expect(rowIsland.gridInitialized.emit).toHaveBeenCalledTimes(1);
expect(rowIsland.gridInitialized.emit).toHaveBeenCalledWith(jasmine.objectContaining({ parentRowData: row.data }));
});
});

describe('IgxHierarchicalGrid Children Sizing #hGrid', () => {
Expand Down
Loading