-
Notifications
You must be signed in to change notification settings - Fork 159
refactor(elements): update with latest source changes #16205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Angular Elements implementation to align with the latest source changes from @angular/elements, updating the change detection strategy and improving the component initialization flow.
- Updates copyright and license information to match Angular's current format
- Replaces custom change detection logic with Angular's new scheduler-based approach
- Simplifies input handling by using the new
setInput
API instead of manual property assignment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
ng-element-strategy.ts | Major refactor to use Angular's scheduler-based change detection and simplified input handling |
custom-strategy.ts | Updates to maintain compatibility with the refactored base strategy class |
Comments suppressed due to low confidence (1)
projects/igniteui-angular-elements/src/app/ng-element-strategy.ts:1
- This TODO comment appears to reference specific implementation details without explaining the complete context or timeline for resolution. Consider providing more detail about when this temporary solution will be addressed.
/* eslint-disable @typescript-eslint/explicit-member-accessibility */
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ɵmarkForRefresh as markForRefresh, | ||
OutputRef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using private Angular APIs (ɵ-prefixed) creates a risk of breaking changes in future Angular versions. Consider if there are public APIs available or document this dependency carefully.
ɵmarkForRefresh as markForRefresh, | |
OutputRef, | |
ChangeDetectorRef, |
Copilot uses AI. Check for mistakes.
@@ -1,11 +1,11 @@ | |||
import { ApplicationRef, ChangeDetectorRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, OnChanges, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core'; | |||
import { ApplicationRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused imports should be removed. ChangeDetectorRef
and OnChanges
were removed from the import but other potentially unused imports like DestroyRef
, QueryList
, and reflectComponentType
remain.
import { ApplicationRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core'; | |
import { ApplicationRef, ComponentFactory, ComponentRef, EventEmitter, Injector, Type, ViewContainerRef } from '@angular/core'; |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
…tegy.ts" This reverts commit 03fdc47.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)