Skip to content

Conversation

damyanpetev
Copy link
Member

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova MayaKirova self-requested a review September 11, 2025 07:45
@MayaKirova MayaKirova added the ✅ status: verified Applies to PRs that have passed manual verification label Sep 11, 2025
@damyanpetev damyanpetev marked this pull request as ready for review September 11, 2025 17:10
@kdinev kdinev requested a review from Copilot September 13, 2025 11:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Angular Elements implementation to align with the latest source changes from @angular/elements, updating the change detection strategy and improving the component initialization flow.

  • Updates copyright and license information to match Angular's current format
  • Replaces custom change detection logic with Angular's new scheduler-based approach
  • Simplifies input handling by using the new setInput API instead of manual property assignment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ng-element-strategy.ts Major refactor to use Angular's scheduler-based change detection and simplified input handling
custom-strategy.ts Updates to maintain compatibility with the refactored base strategy class
Comments suppressed due to low confidence (1)

projects/igniteui-angular-elements/src/app/ng-element-strategy.ts:1

  • This TODO comment appears to reference specific implementation details without explaining the complete context or timeline for resolution. Consider providing more detail about when this temporary solution will be addressed.
/* eslint-disable @typescript-eslint/explicit-member-accessibility */

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +24 to +25
ɵmarkForRefresh as markForRefresh,
OutputRef,
Copy link
Preview

Copilot AI Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using private Angular APIs (ɵ-prefixed) creates a risk of breaking changes in future Angular versions. Consider if there are public APIs available or document this dependency carefully.

Suggested change
ɵmarkForRefresh as markForRefresh,
OutputRef,
ChangeDetectorRef,

Copilot uses AI. Check for mistakes.

@@ -1,11 +1,11 @@
import { ApplicationRef, ChangeDetectorRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, OnChanges, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core';
import { ApplicationRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core';
Copy link
Preview

Copilot AI Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused imports should be removed. ChangeDetectorRef and OnChanges were removed from the import but other potentially unused imports like DestroyRef, QueryList, and reflectComponentType remain.

Suggested change
import { ApplicationRef, ComponentFactory, ComponentRef, DestroyRef, EventEmitter, Injector, QueryList, Type, ViewContainerRef, reflectComponentType } from '@angular/core';
import { ApplicationRef, ComponentFactory, ComponentRef, EventEmitter, Injector, Type, ViewContainerRef } from '@angular/core';

Copilot uses AI. Check for mistakes.

@kdinev kdinev merged commit b7906a5 into master Sep 13, 2025
6 of 9 checks passed
@kdinev kdinev deleted the dpetev/elements-update branch September 13, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💠 grid: elements version: 20.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants