fix(calendar): address SSR issues #16390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonoff
added
❌ status: awaiting-test
didimmova
added
✅ status: verified
didimmova
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds SSR (Server-Side Rendering) safety checks to calendar components by preventing DOM manipulation operations when running in a non-browser environment. The changes ensure that native element focus operations and browser-specific APIs are only called when running in a browser context.
Key changes:
- Added
PlatformUtilinjection to calendar components to detect browser environment - Wrapped all
nativeElement.focus()calls and DOM-dependent operations withplatform.isBrowserchecks - Added null-safety checks for native element references before calling
.focus() - Changed HTML
<caption>element to<div>in calendar template (semantic change)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| years-view.component.ts | Added platform detection and guarded focus call in onMouseDown |
| months-view.component.ts | Added platform detection and guarded focus call in onMouseDown |
| month-picker.component.ts | Added platform checks to multiple focus operations |
| days-view.component.ts | Added platform check to focus call in mouse handler |
| calendar.services.ts | Added early return in keyboard handler attachment for non-browser environments |
| calendar.component.ts | Added platform checks to focus operations and click handlers |
| calendar.component.html | Changed <caption> to <div> and refactored conditional logic to use @switch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16257
@didimmova To test the validity of the fixes in this PR, build the project and test the build with Ignite UI for Angular Samples. You will need to set rendererMode to Prerender for the scheduling samples.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)