Skip to content

refactor: enums with unset state changes #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Dec 10, 2024

Added a proper default auto state for the Stepper title position option.
Textarea inputmode consistent with Input and lib types and switched autocapitalize to optional string on our types just for analyzer's sake and similar to autocomplete

@damyanpetev damyanpetev force-pushed the dpetev/enum-defaults branch from 2b4652a to 5bbb9a9 Compare April 29, 2025 13:09
@damyanpetev damyanpetev force-pushed the dpetev/enum-defaults branch from 5bbb9a9 to d0c541e Compare April 29, 2025 13:40
@damyanpetev damyanpetev changed the title wip enum options changes refactor: enums with unset state changes Apr 29, 2025
@damyanpetev damyanpetev requested a review from rkaraivanov April 29, 2025 13:41
@damyanpetev damyanpetev marked this pull request as ready for review April 29, 2025 13:41
} else {
step.titlePosition = this.titlePosition;
}
step.titlePosition = this.titlePosition;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rkaraivanov rkaraivanov merged commit 6f48208 into master Apr 29, 2025
5 checks passed
@rkaraivanov rkaraivanov deleted the dpetev/enum-defaults branch April 29, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants