refactor(combo): Use key-bindings controller #1529
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the combo component to use the general key-bindings controller from the library. Aside from unifying the implementation across components this also improves several behaviours of the combo: * Keyboard events inside the combo are no longer "swallowed". * Tab navigation is more natural, i.e. there are no longer 2 tab stops per combo component. Updated the combo test suite to accomodate for the changes.
simeonoff
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the combo component to use
the general key-bindings controller from the library. Aside from unifying the implementation across components this also improves several behaviors of the combo:
Updated the combo test suite to accommodate for the changes.