-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global-typography): add global typography stylesheet #296
base: master
Are you sure you want to change the base?
Conversation
@simeonoff Okay, my local build finally produced the extras css file and I have some comments:
Also I saw what happens with components trying to define their own typography and yeah, we're a bit cornered. However, I'm wondering if ignoring items with igc-navbar h1, igc-navbar h2, .... {
font-family:var(--igc-h5-font-family)
//... This should have higher prio, but still only a suggestion. Want to make sure we've exhausted all options here. Alternatively, could we do something with the variables? |
Closes #295
This PR makes it easy to apply the included type category styles for
h1-h6
and body-1 to the native heading(h1-h6) andparagraph
elements.To utilize the typography styles, import or link the
igniteui-webcomponents/themes/extra/typography.css
stylesheet.👻⚠️ IMPORTANT⚠️ 👻
Due to how specificity works for slotted children, using any of the aforementioned elements (h1-h6 and p) with the global typography stylesheet introduced in this PR will overwrite all styles defined by the component using the
::slotted
selector.Example:
h1-h6 and p elements will be excluded from having the global typography styles applied to them if the
slot
orslotted-styles
attributes are set on the element.Example: