mdd-add-shipping-data-service #607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdd-add-shipping-data-service
HUSSAR-mtrela
requested changes
Jul 8, 2024
| public async Task<List<ShippingDataItem>> GetTable() | ||
| { | ||
| using HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri("https://www.igniteui.com/api/orders", UriKind.RelativeOrAbsolute)); | ||
| using HttpResponseMessage response = await _http.SendAsync(request).ConfigureAwait(false); |
There was a problem hiding this comment.
why adding "using" statements in code-behind and not just declare them above "namespace Infragistics.Samples" ?
|
|
||
| public ProductDataService(HttpClient http) | ||
| { | ||
| _http = http; |
There was a problem hiding this comment.
why passing HttpClient if you can create it in an constructor of a ShippingDataService?
| return new List<ShippingDataItem>(); | ||
| } | ||
| } | ||
| public interface IShippingDataService |
There was a problem hiding this comment.
is this interface really needed?
|
|
||
| public async Task<List<ShippingDataItem>> GetTable() | ||
| { | ||
| using HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Get, new Uri("https://www.igniteui.com/api/orders", UriKind.RelativeOrAbsolute)); |
There was a problem hiding this comment.
define the Uri as a variable and then pass it to the http request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdd-add-shipping-data-service