Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Edit Templates on Grid Cell Editing #737

Closed
wants to merge 158 commits into from
Closed

Conversation

MarielaTihova
Copy link
Contributor

Added edit templates on the grid/editing-columns sample for React, Blazor, Web Components, so that behaviour is the same as in the Angular sample.

Closes #735

@HUSSAR-mtrela HUSSAR-mtrela changed the base branch from 24.1.x to 24.2.x December 3, 2024 23:18
@skrustev skrustev self-requested a review March 6, 2025 07:56
@skrustev
Copy link
Member

skrustev commented Mar 6, 2025

Looks good. Only suggestion I would make is maybe focusing the templated input when entering edit mode for the cell. Mainly because at the moment if you use keyboard navigation you cannot change the value and you will need to click on the input again.

@MarielaTihova
Copy link
Contributor Author

Closing this PR and opening a new one with a clearer git history here #823. Please refer to it for changes related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor Grid Cell Editing and Edit Templates Example does not have an edit template
9 participants