Feature: Added support for BlackListing Domains. #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ImMattDavison Please review my PR, Thank you. |
|
@hkmekala please fix merge conflicts |
|
@ImMattDavison Will do it today. |
|
Closing this PR as abandoned. |
|
Reopening due to reclaimation |
|
@hkmekala will you be completing this? |
|
Pls give me till Dec 15th
On Fri, 25 Nov 2022 at 7:26 PM, Matt Davison ***@***.***> wrote:
@hkmekala <https://github.com/hkmekala> will you be completing this?
—
Reply to this email directly, view it on GitHub
<#106 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACP2P26KV2CDX3FUVHUI4CDWKDASTANCNFSM6AAAAAARSOO3U4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Cheers
Harikrishna Mekala
…--
This email (including any attachments) may contain confidential,
proprietary, privileged and/or private information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or any
attachments by an individual or entity other than the intended recipient is
prohibited. For more detailed information and disclosures, please refer to
the Terms and Conditions on our website
<https://www.smallcase.com/meta/disclosures>
|
|
@ImMattDavison I can add the domain blocklist the same way I added the whitelist |
|
This would be appreciated, should I assign the issue to you? @Rutuj-Runwal |
|
@ImMattDavison Yes that will be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #103
Added support for blacklisting domains.