IDC-1215: CCC uni/bidirectional annotations to Cornerstone tool state #81
Conversation
dcmjs * @ohif/core: 0.18.5 → 0.18.6 * @ohif/extension-cornerstone: 0.18.4 → 0.18.6 * @ohif/extension-dicom-html: 0.18.5 → 0.18.6 * @ohif/extension-dicom-rt: 0.18.5 → 0.18.6 * @ohif/extension-dicom-segmentation: 0.18.5 → 0.18.6 * @ohif/extension-dicom-tag-browser: 0.18.5 → 0.18.6 * @ohif/extension-vtk: 0.18.5 → 0.18.6 * @ohif/viewer: 0.18.5 → 0.18.6
There was a problem hiding this comment.
just some questions, since I am not familiar with SR:
- why is this PR not pushed to https://github.com/OHIF/Viewers as well?
- Is this a IDC customization since CrowdsCureCancer identifiers are IDC specifics? would this mean that this PR will not work with "general"/"standard" uni/bidirectional annotations?
- could you please give a brief summary which SR annotations this PR implements, what is already available in the OIHF viewer and what is missing in the context of Add DICOM SR Support for additional/common annotations OHIF/Viewers#1215 and http://docs.google.com/document/d/1bR6m7foTCzofoZKeIRN5YreBrkjgMcBfNA7r9wXEGR4/?
@Punzo to get you up to speed... This is IDC specific request. There's an open discussion here and here about a better way to store planar annotations using Clunie's paper. It's not a solid standard but the path we should take, we still need to come up with a solid representation + solid matching that would cover other annotations + including some math checks but this will require more thought and more people. This is a temporary solution for the current implementation that uses tracking identifiers as the key to mapping from SR to a Cornerstone annotation. The problem is that this tracking identifier is populated with Cornerstone tool info only for OHIF STOWRS. Using a tracking identifier to do this mapping is not right but it was a valid POC at the time because it doesn't require smart matching SR properties / scoord to a Cornerstone annotaiton. Since these CCC annotations were generated somewhere else + are uni/bi-directional annotations only, i just added a simple and straightforward check for long axis or length (okey for this scope). |
OK, thanks for the explanation! |
|
@igoroctaviano can you please:
Here's the test study with CCC annotations, which does not work for me: https://idc-sandbox-000.firebaseapp.com/projects/idc-tcia/locations/us-central1/datasets/tcia-idc-datareviewcoordination/dicomStores/CrowdsCure/study/1.3.6.1.4.1.14519.5.2.1.9203.4004.100545948082587796019777812429 |
I just asked Bill to check that + ask if we have IDC-specific version files to update to keep track. |
Uses a new dcmjs Cornerstone MeasurementReport hook to allow defining Crowds Cure Canter matching logic to map a measurement group to a Cornerstone tool class instead of relying on CCC random tracking identifiers e.g. "web annotation" which doesn't work for current SR hydration implementation