Creates the validators registry #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
approved these changes
Oct 23, 2024
| VALIDATORS_REGISTRY[name] = cls | ||
| return cls | ||
|
|
||
| return decorator |
There was a problem hiding this comment.
I'd usually use the decorator package for this to simplify the syntax a little: https://pypi.org/project/decorator/
But this is totally fine as is.
There was a problem hiding this comment.
I don't think this works well with classes, in particular in this case where we are just registering the class using an input to the decorator itself, not the function. So skipping, for now.
| mock_write_csv.assert_not_called() | ||
|
|
||
| KNOWN_WRITERS.clear() | ||
| KNOWN_WRITERS.append(MagicMock(return_value=False)) | ||
| write_data(filename, data, comment, **csv_options) | ||
| KNOWN_WRITERS[0].assert_called_once_with(filename, data, comment, **csv_options) | ||
| KNOWN_WRITERS[0].assert_called_once_with( # type: ignore [attr-defined] |
There was a problem hiding this comment.
You could also get mypy to ignore the tests folder if you can't be bothered with all these type: ignores.
There was a problem hiding this comment.
It has caught a few issues, so I rather not exclude the tests and just ignore the problematic lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, run the validators when reading the header, converting the relevant fields into a pydantic object, and dump the data into dictionaries from the pydantic models when writing the data.
Close #79