Fix: A few missing re-exports from root module #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsoa
approved these changes
Jan 28, 2025
|
Nw. It looks like it's waiting on some non-existing CI checks to finish... Did you change the CI config recently? |
|
Yep, its in the other PR. Sorry. I'll merge this as soon as I've tackled the comments in the other and merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with things and noticed that
read_to_dictandread_to_listare not re-exported from the maincsvypackage, unlike the other readers, so you have to import them fromcsvy.readersinstead, which seems a bit inconsistent.I also changed the tests for the readers to import from
csvyrather thancsvy.readersso we can check things are exported properly.