Correct code in the servo example #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guamoko995
reviewed
Nov 15, 2025
| .configure(channel::config::Config { | ||
| timer: &hstimer0, | ||
| duty_pct: 10, | ||
| duty_pct: 100, |
Author
There was a problem hiding this comment.
I think by setting it to 100, we are saying that we want to control all 100% of the duty cycle.
Contributor
There was a problem hiding this comment.
I think by setting it to 100, we are saying that we want to control all 100% of the duty cycle.
It seems to me that this only sets the initial value of the duty cycle.
The issue has already been fixed here: #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the code you meant to write.