Skip to content

Pintail-88: Initialize stats emitter only after the successful initialization of cosnumer #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajubairishetti wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Pintail-88: Initialize stats emitter only after the successful initialization of cosnumer #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1caa41f
Pintail-88: Initialize stats emitter only after the successful initia…
May 6, 2015
df7a75d
start stats exposer for the reader if reader is created successfully
May 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...ging-client-core/src/main/java/com/inmobi/messaging/consumer/AbstractMessageConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,12 @@ public void init(String topicName, String consumerName, Date startTimestamp,
&& startTime.after(new Date(System.currentTimeMillis()))) {
throw new IllegalArgumentException("Future start time is not accepted");
}
init(config);
metrics = (BaseMessageConsumerStatsExposer) getMetricsImpl();
String emitterConfig = config
.getString(MessageConsumerFactory.EMITTER_CONF_FILE_KEY);
if (emitterConfig != null) {
statsEmitter.init(emitterConfig);
}
init(config);
metrics = (BaseMessageConsumerStatsExposer) getMetricsImpl();
if (emitterConfig != null) {
statsEmitter.add(metrics);
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...g-client-databus/src/main/java/com/inmobi/messaging/consumer/databus/DatabusConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ protected void createPartitionReaders() throws IOException {
PartitionReaderStatsExposer collectorMetrics = new
CollectorReaderStatsExposer(topicName, consumerName,
id.toString(), consumerNumber, fsuri);
addStatsExposer(collectorMetrics);
Path streamsLocalDir = null;
if (readFromLocalStream) {
streamsLocalDir = DatabusUtil.getStreamDir(StreamType.LOCAL,
Expand All @@ -214,6 +213,7 @@ protected void createPartitionReaders() throws IOException {
new Path(streamDir, collector), streamsLocalDir, buffer, topicName,
partitionTimestamp, waitTimeForFlush, waitTimeForFileCreate,
collectorMetrics, stopTime));
addStatsExposer(collectorMetrics);
messageConsumedMap.put(id, false);
numList = 0;
}
Expand All @@ -228,12 +228,12 @@ protected void createPartitionReaders() throws IOException {
PartitionReaderStatsExposer clusterMetrics =
new PartitionReaderStatsExposer(topicName, consumerName,
id.toString(), consumerNumber, fsuri);
addStatsExposer(clusterMetrics);
readers.put(id, new PartitionReader(id,
partitionCheckpointList, fs, buffer, streamDir, conf,
DatabusInputFormat.class.getCanonicalName(), partitionTimestamp,
waitTimeForFileCreate, true, clusterMetrics, partitionMinList,
stopTime));
addStatsExposer(clusterMetrics);
messageConsumedMap.put(id, false);
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ing-client-databus/src/main/java/com/inmobi/messaging/consumer/hadoop/HadoopConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,14 @@ protected void createPartitionReaders() throws IOException {
PartitionReaderStatsExposer clusterMetrics =
new PartitionReaderStatsExposer(topicName, consumerName, id.toString(),
consumerNumber, fsUri);
addStatsExposer(clusterMetrics);
PartitionReader reader = new PartitionReader(id,
partitionCheckpointList, fileSystems[i], buffer, rootDirs[i],
conf, inputFormatClassName, partitionTimestamp,
waitTimeForFileCreate, false, clusterMetrics, partitionMinList,
stopTime);
LOG.debug("Created partition " + id);
readers.put(id, reader);
addStatsExposer(clusterMetrics);
messageConsumedMap.put(id, false);
}
}
Expand Down