Skip to content

Scribe log messages should have millisecond level timestamp #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajubairishetti wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Scribe log messages should have millisecond level timestamp #36

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce2d33
append millisec level time to logs
rajubairishetti Aug 13, 2014
8445fe9
Merge branch 'master' into Scribe-23
rajubairishetti Aug 13, 2014
23e0ab4
remove an extra time() call
rajubairishetti Aug 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/env_default.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ const std::string scribeversion("2.2");
time(&now); \
ctime_r(&now, dbgtime); \
dbgtime[24] = '\0'; \
fprintf(stderr,"[%s] " #format_string " \n", dbgtime,##__VA_ARGS__); \
struct timeval tv; \
gettimeofday(&tv, NULL); \
Copy link
Copy Markdown

@satish-mittal satish-mittal Aug 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces one extra call. Try the following:

  • first call gettimeofday()
  • take tv.sec and pass it to ctime_r()
  • together print sec and millisec parts

long numMillis = (tv.tv_usec / 1000); \
fprintf(stderr,"[%s %ld] " #format_string " \n", dbgtime,numMillis,##__VA_ARGS__); \
}


Expand Down