feat: 添加嵌入算子 #15
Draft
feat: 添加嵌入算子 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanZezhong1725
requested changes
Apr 7, 2025
infiniop/ops/embed/README.md
Outdated
| $$ Y = \alpha_1 \cdot table_1[i_1] + \alpha_2 \cdot table_2[i_2] $$ | ||
|
|
||
| - 通常 $α$ 为 1； | ||
| - 某一项的 $α$ 为 0、$table$ 为空或 $i$ 为空表示不使用； |
There was a problem hiding this comment.
table显示不正常。
建议只有table2可以为空
infiniop/ops/embed/README.md
Outdated
| `infiniopCreateEmbedDescriptor` 指针，指向将被初始化的算子描述符地址； | ||
| - `y_desc` - $\{ dT | (N, D) | (..., 1) \}$: | ||
| 算子输出 `y` 的张量描述； | ||
| - `table1_desc` - $\{ dT | (..., D) | (..., 1) \}$: |
There was a problem hiding this comment.
如果是二维你可以随便写个字母，比如 (B,D)
infiniop/ops/embed/README.md
Outdated
| 算子输入 `table1` 的张量描述； | ||
| - `table2_desc` - $\{ dT | (..., D) | (..., 1) \}$: | ||
| 算子输入 `table2` 的张量描述； | ||
| - `i1_desc` - $\{ dT_i | (N) | (1) \}$: |
There was a problem hiding this comment.
类型叫dI吧，下标不好看。把可以为nullptr这事说一下，要求alpha2必须为0
There was a problem hiding this comment.
那就是要求为空的时候几项必须对应同时表示空？也行
infiniop/ops/embed/README.md
Outdated
|
|
||
| 参数限制： | ||
|
|
||
| - $dT$: 任意浮点类型； |
There was a problem hiding this comment.
只要支持乘加，可能是排除 bool 都行，但是不知道怎么表示
There was a problem hiding this comment.
任意浮点数、整数、无符号整数类型？我觉得是不是bool也可以有啊
| 计算输出结果； | ||
| - `table1`: | ||
| 第 1 个嵌入表； | ||
| - `table2`: |
|
|
||
| <div style="background-color: lightblue; padding: 1px;"> 返回值：</div> | ||
|
|
||
| - [`INFINI_STATUS_SUCCESS`], [`INFINI_STATUS_BAD_PARAM`], [`INFINI_STATUS_BAD_TENSOR_SHAPE`], [`INFINI_STATUS_BAD_TENSOR_DTYPE`], [`INFINI_STATUS_BAD_TENSOR_STRIDES`], [`INFINI_STATUS_BAD_DEVICE`]. |
There was a problem hiding this comment.
加个 INFINI_STATUS_NULL_POINTER
PanZezhong1725
requested changes
Apr 7, 2025
YdrMaster
force-pushed
the
main
branch
3 times, most recently
from
5095b37 to
e75be11
Compare
PanZezhong1725
requested changes
Apr 15, 2025
infiniop/ops/embedding/README.md
Outdated
| $$ Y = \alpha_1 \cdot table_1[i_1] + \alpha_2 \cdot table_2[i_2] $$ | ||
|
|
||
| - 通常 $α$ 为 1； | ||
| - $ table2 $ 可以不使用，则公式变为 $ Y = \alpha_1 \cdot table_1[i_1] $； |
infiniop/ops/embedding/README.md
Outdated
| `infiniopHandle_t` 类型的硬件控柄。详情请看：[`InfiniopHandle_t`] | ||
| - `desc_ptr`: | ||
| `infiniopCreateEmbeddingDescriptor` 指针，指向将被初始化的算子描述符地址； | ||
| - `y_desc` - $\{ dT | (N, D) | (..., 1) \}$: |
There was a problem hiding this comment.
这个张量格式不需要用数学符号了，正常写就行
infiniop/ops/embed/README.md
Outdated
| `infiniopCreateEmbedDescriptor` 指针，指向将被初始化的算子描述符地址； | ||
| - `y_desc` - $\{ dT | (N, D) | (..., 1) \}$: | ||
| 算子输出 `y` 的张量描述； | ||
| - `table1_desc` - $\{ dT | (..., D) | (..., 1) \}$: |
There was a problem hiding this comment.
如果是二维你可以随便写个字母，比如 (B,D)
infiniop/ops/embed/README.md
Outdated
|
|
||
| 参数限制： | ||
|
|
||
| - $dT$: 任意浮点类型； |
There was a problem hiding this comment.
任意浮点数、整数、无符号整数类型？我觉得是不是bool也可以有啊
Signed-off-by: YdrMaster <[email protected]>
YdrMaster
force-pushed
the
main
branch
2 times, most recently
from
aec7ab8 to
9bb9ffe
Compare
Signed-off-by: YdrMaster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.