Skip to content

fix: Issues in mailer identified and fixed - #189

Merged
IAmRiteshKoushik merged 1 commit into
devfrom
fix/mail
Dec 17, 2025
Merged

IAmRiteshKoushik merged 1 commit into
devfrom
fix/mail

Conversation

@Thanus-Kumaar

Copy link
Copy Markdown
Collaborator

Problems and Solutions:

  1. "Invalid Data Type" Error: Emails were failing with an "invalid data type for 'otp' email template" error after being
    re-enqueued. I guess this happened because after serialization and deserialization of the EmailRequest in the queue, the data type is changing from pointers to plain struct.

Therefore updated the validation to accept both pointers and struct

  1. Redundant Retries: I think it is better to just push the mail back to the queue instead of trying again for 3 times. I saw that we are already trying 3 times inside the Send() function

I just removed the external retries

@IAmRiteshKoushik IAmRiteshKoushik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IAmRiteshKoushik
IAmRiteshKoushik merged commit ee9441a into dev Dec 17, 2025
1 check failed
@IAmRiteshKoushik
IAmRiteshKoushik deleted the fix/mail branch December 22, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants