fix: Remove useless property since multiPassword #2045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambrdctr
force-pushed
the
fix/multi-password
branch
from
dff3767 to
c511a36
Compare
Ambrdctr
force-pushed
the
fix/multi-password
branch
from
6377c5f to
cbb0692
Compare
|
There was a problem hiding this comment.
Pull request overview
This PR removes obsolete password validation properties from the Mailbox model following the introduction of multi-password support. The properties isPasswordValid and isValidInLDAP are no longer needed, along with their derived computed properties isConsideredLocked and isAvailable.
Key Changes:
- Removed password-related properties from the Mailbox model and simplified availability logic to use only
isLocked - Updated all mailbox availability checks throughout the codebase to use the simplified
!isLockedlogic - Removed UI components and localized strings related to password-blocked mailboxes
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MailCore/Models/Mailbox.swift | Removed isPasswordValid, isValidInLDAP persisted properties and isConsideredLocked, isAvailable computed properties; updated initializer, decoder, and CodingKeys |
| MailCore/Cache/MailboxInfosManager/MailboxInfosManager.swift | Incremented database schema version from 15 to 16 for the property removal |
| MailCore/Cache/AccountManager/AccountManager.swift | Replaced all isAvailable checks with !isLocked throughout mailbox filtering and selection logic |
| MailCore/Cache/RootViewState.swift | Updated unavailable mailboxes check to use isLocked instead of isAvailable |
| MailCoreUI/Helpers/PreviewHelper.swift | Removed obsolete isPasswordValid and isValidInLDAP parameters from sample mailbox creation |
| Mail/Components/UnavailableMailboxListView.swift | Removed password-blocked mailboxes section and related filtering logic |
| MailResources/Localizable/*.lproj/Localizable.stringsdict | Removed blockedPasswordTitle localized string entries across all language files (en, de, es, fr, it) |
PhilippeWeidmann
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.