fix: remove trailing slashes from envoyproxy repository URLs in Chart.yaml #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InftyAI-Agent
added
needs-triage
|
/retest |
|
/lgtm |
InftyAI-Agent
added
lgtm
|
Thanks @OKevinoo welcome on board! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fix the bug of "invalid repository" error when installing llmaz via "make helm-install". The original source code failed to go through the whole process of installing from source option due to the bug. After removing the two "/"s in Chart.yaml, this problem disappeared.
Which issue(s) this PR fixes
Fixes #406
Special notes for your reviewer
I have attached two screenshots that clearly displayed the difference. I've tested many times on various networks and servers, the previous bug appeared every time, and also I've tested through different networks on different servers after removing the "/", the installation went smoothly.
Error:
After:
Does this PR introduce a user-facing change?