Update tests for throwing exception with inputs #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowekamp
commented
Feb 28, 2025
|
|
||
| EXPECT_NO_THROW(filter->SetConstant1(1)); | ||
| EXPECT_NO_THROW(filter->GetInput()); | ||
| EXPECT_ANY_THROW(filter->GetInput()); |
Member
Author
There was a problem hiding this comment.
Looks like this case throws in debug but not release... This behavior comes from the Ternay ( and maybe binary ) base classes.
Inputs slots can have multiple types, current behavior is to throw an exception when the getter does not match the current type. For example if a image is asked for when a constant is set.
hjmjohnson
force-pushed
the
fix_input_throw
branch
from
e25189f to
e5835df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputs slots can have multiple types, current behavior is to throw an exception when the getter does not match the current type. For example if a image is asked for when a constant is set.