Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParallelStates not reacting to global triggers #54

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

TdXYZ
Copy link
Contributor

@TdXYZ TdXYZ commented Sep 15, 2024

Fixes issue #48

@Inspiaaa
Copy link
Owner

Hi @TdXYZ,

Thanks for the fix to the ParallelStates class not reacting to global triggers, and for including the unit tests! I really appreciate your contribution.

I will merge your PR shortly.

Regarding the potential issue you highlighted in #48 that a ParallelStates state may exit during iteration - meaning that the trigger is called on states that are no longer part of the active hierarchy -, I think I have found a solution. I am going to implement it before releasing the next version of UnityHFSM 👍

@Inspiaaa Inspiaaa merged commit d1f47dd into Inspiaaa:master Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants