Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Unpin conda-build #1980

Merged
merged 2 commits into from
Jan 27, 2025
Merged

[MAINT] Unpin conda-build #1980

merged 2 commits into from
Jan 27, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jan 27, 2025

This PR proposes unpinning conda-build in the conda-package workflow, as well as updating the workflow to account for conda-build (after 25.1.0) moving to producing .conda files instead of tarballs.

The change to .conda files is motivated by improvements to package compression, which bring dpctl from ~24 MB to ~13.5 MB, about a 40% decrease in size.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jan 27, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025

Coverage Status

coverage: 88.24%. remained the same
when pulling c612f93 on permit-conda-build-25-1-1
into 7bc3d80 on master.

conda-build 25.1.1 now outputs .conda files instead of tarballs
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_499 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian marked this pull request as ready for review January 27, 2025 04:43
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleksandr-pavlyk
Copy link
Collaborator

PR is lacking description of intent of the change. Is the reason for the change to produce .conda artifacts, or is the change to .conda consequence of updating version of conda-build, which was on a to-do list for some time?

@ndgrigorian
Copy link
Collaborator Author

PR is lacking description of intent of the change. Is the reason for the change to produce .conda artifacts, or is the change to .conda consequence of updating version of conda-build, which was on a to-do list for some time?

Yes, great point, I'll fix that by adding a PR description. :)

It's a consequence of the workflow using conda-build 25.1.1, which produces .conda instead of tarballs by default. The reason is apparently due to improved compression.

@ndgrigorian
Copy link
Collaborator Author

For example of the compression, before:
Before

after:
After

@ndgrigorian ndgrigorian merged commit bfd4d57 into master Jan 27, 2025
72 of 73 checks passed
@ndgrigorian ndgrigorian deleted the permit-conda-build-25-1-1 branch January 27, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants