Skip to content

update sign function for complex numbers #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 26, 2025

definition of sign function is changed for numpy-2.*

@vtavana vtavana self-assigned this Apr 26, 2025
@ndgrigorian
Copy link
Collaborator

@vtavana
should we add conditional definition based on if NumPy > 2? Since we still are supporting 1.26.4

@vtavana
Copy link
Collaborator Author

vtavana commented Apr 28, 2025

@vtavana should we add conditional definition based on if NumPy > 2? Since we still are supporting 1.26.4

@ndgrigorian Yes, I am planning to do it. The PR is a draft and not finalized yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants