This repository was archived by the owner on Nov 23, 2023. It is now read-only.
bug fixes in mrp.py and new convenience functions to update the qualities of all active notes #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrp listens to all incoming osc
mrp.py new update_qualities_all, update_quality_all
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After finally merging the changes from your master branch, I fixed update_qualities() and note_on_numbers() in mrp.py and added two new functions, update_qualities_all() and update_quality_all(), to update the given qualities for all currently active notes.
This also has the updated async repeat decorator that I already tested back at the lab in december. I'm not sure if @jarmitage got around to testing it, yet.