Feat/local docker sandbox #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DockerSandbox provider for air-gapped/local deployments - Add PortPoolManager for centralized port allocation (30000-30999) - Add LocalStorage providers for ii_agent and ii_tool - Add MCP tool image processing from sandbox containers - Add storage factory functions with local/GCS support - Add test suite (143 tests passing) - Fix connect() to register ports preventing conflicts on reconnect - Fix delete() to cleanup orphaned volumes - Update docs with port management and local sandbox setup
Chat file handling:
- Fix file_search filtering by user_id only (not session_id) for cross-session access
- Add SHA-256 content hash deduplication in OpenAI vector store
- Reduce file_search max results to 3 to prevent context overflow
- Add file corpus discovery so AI knows which files are searchable
- Fix reasoning.effort parameter only sent to reasoning models
- Add hasattr guard for text attribute on image-only messages
Sandbox management:
- Add orphan cleanup loop (5min interval) to remove containers without active sessions
- Add /internal/sandboxes/{id}/has-active-session endpoint for session verification
- Add port_manager.scan_existing_containers() to recover state on restart
- Add LOCAL_MODE config with orphan cleanup settings
Resource limits:
- Add MAX_TABS=20 limit in browser with force-close of oldest tabs
- Add MAX_SHELL_SESSIONS=10 limit in shell tool
Tests: Add 248 unit tests covering all changes
## New Features - expose_port(external) parameter: external=True returns localhost:port for browser access, external=False returns internal Docker IP for container-to-container communication - LLMConfig.get_max_output_tokens(): Model-specific output token limits (64K Claude 4, 100K o1, 16K GPT-4, 8K Gemini) - Browser MAX_TABS=20 limit with automatic cleanup of oldest tabs - Shell session MAX_SHELL_SESSIONS=15 limit with clear error messages - Anthropic native thinking blocks support via beta endpoint - Extended context (1M tokens) support for Claude models ## Frontend Improvements - Added selectIsStopped selector for proper stopped state UI handling - Fixed agent task state transitions for cancelled sessions - Improved subagent container with session awareness ## New Test Coverage (343 tests total) - tests/llm/test_llm_config.py: LLMConfig.get_max_output_tokens() tests - tests/tools/test_browser_tab_limit.py: Browser MAX_TABS enforcement - tests/tools/test_resource_limits.py: Browser and shell session limits - tests/tools/test_generation_config_factory.py: Image/video generation configs - tests/tools/test_openai_dalle.py: DALL-E 3 image generation client - tests/tools/test_openai_sora.py: Sora video generation client - tests/storage/test_local_storage.py: LocalStorage.get_permanent_url() - tests/storage/test_tool_local_storage.py: Tool server LocalStorage ## Code Quality - Removed debug print statements from anthropic.py - Removed trailing whitespace from all files - Fixed test assertions to match implementation behavior
…proposed changes.
Author
|
Hi, dev team, loving this framework! I put it to the test by first making it run airgapped (save secure foundation providers such as Pinecone and Anthropic), plugged in my new mcp server (knowledge base for seating/mobility vertical, able to easily overwhelm any model's context unless carefully controlled/tuned). Found a few stability issues and made some proposed fixes along the way. All is open for constructive criticism, discussion and debate. |
## Resource Management - Browser: Increase MAX_TABS from 20 to 50 - Browser: Enforce tab limit in _on_page_change handler for popups/target=_blank - Shell: Auto-close oldest session when MAX_SHELL_SESSIONS limit reached (replaces error-based rejection) ## Admin Tools - Add scripts/admin_credits.sh for user credit management - list: View all users and balances - show/topup/set/bonus: Manage individual user credits ## Documentation - Fix SANDBOX_DATABASE_URL to use asyncpg driver in .stack.env.local.example - Update feature-branch-analysis.md: Claude 3.5 → Claude 4.5, improve wording ## Tests - Update browser tests for MAX_TABS=50 - Add tests for _on_page_change tab limit enforcement - Update shell tests for auto-close behavior ## Build - uv.lock: Add prerelease-mode = "allow" option
…tension architecture docs - Refactor run_stack.sh to support both cloud (E2B/ngrok) and local-only (Docker sandbox) modes - Add start, stop, restart, status, logs, build, and setup commands - Implement auto-detection of local mode based on env file presence - Auto-create env files from templates with helpful setup instructions - Add --local flag for explicit local mode selection - Fix color output using $'...' syntax and printf for portability - Add VS Code extension architecture documentation with detailed design specs - Add executive summary document for VS Code extension integration
Converts HTML files (slides, pages, etc.) to a single multi-page PDF using Playwright/Chromium. Each HTML file becomes exactly one page with full content capture (no truncation). Features: - Automatic content height detection - Configurable viewport width and DPI - Supports directory input or specific files - Progress output with quiet mode option
…s, pages, etc.) to a single multi-page PDF\nusing Playwright/Chromium. Each HTML file becomes exactly one page\nwith full content capture (no truncation).\n\nFeatures:\n- Automatic content height detection\n- Configurable viewport width and DPI\n- Supports directory input or specific files\n- Progress output with quiet mode option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Local Docker Sandbox Provider & Resource Management
Summary
This PR introduces a complete local Docker sandbox provider for air-gapped/local deployments, comprehensive resource management limits, and extensive test coverage (~343 new tests).
Key Features
🐳 Local Docker Sandbox Provider
/internal/sandboxes/{id}/has-active-sessionendpoint for session verification💾 Local Storage Providers
LocalStorageproviders for bothii_agentandii_tool🔒 Resource Management
MAX_TABSlimit with automatic cleanup of oldest tabs_on_page_changenow enforces tab limits on externally-created pages (popups, target="_blank")MAX_SHELL_SESSIONS=10limit with auto-close of oldest session when limit reached🧠 LLM Enhancements
LLMConfig.get_max_output_tokens(): Model-specific output token limits (64K Claude 4, 100K o1, 16K GPT-4, 8K Gemini)💬 Chat Improvements
🎨 Frontend
Test Coverage
125 files changed, 16,573 insertions(+), 297 deletions(-)
New test files:
test_browser_tab_limit.py- Browser MAX_TABS enforcementtest_resource_limits.py- Browser and shell session limitstest_shell_tools.py- Shell session managementtest_llm_config.py- LLM configurationtest_generation_config_factory.py- Image/video generation configstest_openai_dalle.py / test_openai_sora.py- Media generation clientstest_local_storage.py / test_tool_local_storage.py- Storage providerstest_file_*.py- File operation toolstest_terminal_manager.py- Terminal session managementCode Quality
Added comprehensive documentation for architecture and design