Skip to content

Upgrade to 2022.3.60f1 LTS #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

Z-Machine
Copy link

This PR supersedes the initial work done by Interkarma on his branch.

This upgrade fixes multiple breaking issues I've experienced under Wayland in the unity2019 editor and also fixes #2728

Currently everything vanilla seems to work in the editor and in my local build on Linux. I haven't got around to testing mods yet but there doesn't seem to have been any apparent breaking changes.

I'd love to help get this tested and pushed through as I'm sorely lacking newer language features in C# and support for SourceGenerators. 🙏

@KABoissonneault
Copy link
Collaborator

I'm most concerned with precompiled mods, which link to specific details of Unity binaries. If we can find some of them and verify that they work without errors, I'd be good with it

@Z-Machine
Copy link
Author

I've got a local build running with ~110 mods in my current save, it's playable but there are some issues.

It seems Unity has changed how they handle improperly sized DXT5 textures which is causing them to fail to load instead of falling back to RGBA32 which will need to be addressed.

Additionally, around five mods are failing to initialize due to types being incomplete during reflection, and UBLAMF's update checker is failing to compile from source.

@Z-Machine
Copy link
Author

Did some initial work over at Z-Machine#1 to replace the runtime compiler with Roslyn. Currently it fixes my above described issue with mods.

@Z-Machine Z-Machine marked this pull request as draft March 20, 2025 23:22
@Z-Machine
Copy link
Author

image
image

There are a lot of Texture2Ds being created all over the codebase but the above commit re-implements the fallback behavior.

@KABoissonneault
Copy link
Collaborator

KABoissonneault commented Mar 21, 2025

I think we'll need a test build and community testing once you have a build you think is stable enough for general users. I think we'll need to compile a list of broken mods, and see which ones can be updated or not to fit.

The situation I'm trying to avoid is splitting the community into a new and an old version, where the old version has that one cool mod that simply cannot be ported to the new one. I certainly won't maintain two engine versions, so people on the old version will be stuck with old issues forever. This will also create an extra maintenance burden on all modders, who will have to release their mods for both versions.

But if after testing, it turns out that the impact is minor and people can cope (it only breaks mods that people shouldn't be using anymore anyway), then I'd be excited to upgrade for sure.

Thank you for looking into this, I simply don't have the bandwidth for anything that takes multiple hours myself.

PS: I was looking into have exception reports and error message for users into main DFU for some time, maybe we could get that in too

Z-Machine and others added 7 commits March 23, 2025 19:36
Replace runtime compiler with Roslyn and remove old compiler from project.

- Enables nullable types
- LangVersion is now 11
- Mods can now be built in debug mode and the game loads their pdb if found
@Z-Machine
Copy link
Author

I think we'll need a test build and community testing once you have a build you think is stable enough for general users.

I've got standalone builds published on my fork and have made a forum post, hopefully it generates some interest.

@Z-Machine
Copy link
Author

The above commit fixes several mods crashing at runtime as noted by Excoriated for the following mods:

Ambient Text 1.7
Diverse Weapons 1.7
Dungeon Loot 2.0
Famous Face of the Iliac Bay 2.0.1
Readied Spellcasting Hands 0.11.4
Sit and Loiter 1.2
The Red Lantern Guild 2.0
Uncanny UI 1.2 (not jagget fork, jagget fork works)
Villager Reactions 1.2

I am unable to reproduce the crashes under Arch but they says it fixes the crashes for them under Win10.

I've also uploaded a new release over on my fork.

@Z-Machine
Copy link
Author

Z-Machine commented Mar 29, 2025

2022 added a new default input setting that maps physical key locations to key codes per keyboard layout/locale. The above commit reverts this to 2019 behavior until we can switch to the new default setting.

As of 2022.1 the option is enabled by default with intent of deprecating and removing old behavior in the future.

https://docs.unity3d.com/2022.3/Documentation/Manual/UpgradeGuide2022LTS.html#keys"

Much thanks to Excoriated for finding this issue.

@Z-Machine Z-Machine marked this pull request as ready for review May 16, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linux] Daggerfall Unity won't start in pure Wayland environment
2 participants