-
Notifications
You must be signed in to change notification settings - Fork 355
Upgrade to 2022.3.60f1 LTS #2733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I'm most concerned with precompiled mods, which link to specific details of Unity binaries. If we can find some of them and verify that they work without errors, I'd be good with it |
I've got a local build running with ~110 mods in my current save, it's playable but there are some issues. It seems Unity has changed how they handle improperly sized DXT5 textures which is causing them to fail to load instead of falling back to RGBA32 which will need to be addressed. Additionally, around five mods are failing to initialize due to types being incomplete during reflection, and UBLAMF's update checker is failing to compile from source. |
Did some initial work over at Z-Machine#1 to replace the runtime compiler with Roslyn. Currently it fixes my above described issue with mods. |
I think we'll need a test build and community testing once you have a build you think is stable enough for general users. I think we'll need to compile a list of broken mods, and see which ones can be updated or not to fit. The situation I'm trying to avoid is splitting the community into a new and an old version, where the old version has that one cool mod that simply cannot be ported to the new one. I certainly won't maintain two engine versions, so people on the old version will be stuck with old issues forever. This will also create an extra maintenance burden on all modders, who will have to release their mods for both versions. But if after testing, it turns out that the impact is minor and people can cope (it only breaks mods that people shouldn't be using anymore anyway), then I'd be excited to upgrade for sure. Thank you for looking into this, I simply don't have the bandwidth for anything that takes multiple hours myself. PS: I was looking into have exception reports and error message for users into main DFU for some time, maybe we could get that in too |
Replace runtime compiler with Roslyn and remove old compiler from project. - Enables nullable types - LangVersion is now 11 - Mods can now be built in debug mode and the game loads their pdb if found
I've got standalone builds published on my fork and have made a forum post, hopefully it generates some interest. |
The above commit fixes several mods crashing at runtime as noted by Excoriated for the following mods: Ambient Text 1.7 I am unable to reproduce the crashes under Arch but they says it fixes the crashes for them under Win10. I've also uploaded a new release over on my fork. |
2022 added a new default input setting that maps physical key locations to key codes per keyboard layout/locale. The above commit reverts this to 2019 behavior until we can switch to the new default setting.
https://docs.unity3d.com/2022.3/Documentation/Manual/UpgradeGuide2022LTS.html#keys" Much thanks to Excoriated for finding this issue. |
This PR supersedes the initial work done by Interkarma on his branch.
This upgrade fixes multiple breaking issues I've experienced under Wayland in the unity2019 editor and also fixes #2728
Currently everything vanilla seems to work in the editor and in my local build on Linux. I haven't got around to testing mods yet but there doesn't seem to have been any apparent breaking changes.
I'd love to help get this tested and pushed through as I'm sorely lacking newer language features in C# and support for SourceGenerators. 🙏