Fix PlaceNpc action not serializing marker #2742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Assign Foe to Place | ||
| place.AssignQuestResource(foeSymbol, marker); | ||
| place.AssignQuestResource(foe.Symbol, marker); |
Collaborator
There was a problem hiding this comment.
Just curious, is there any way foeSymbol could differ from foe.Symbol?
Contributor
Author
There was a problem hiding this comment.
AFAIK foe.Symbol would be set in Foe.SetResources(), which parses quest definitions (e.g. Foe _mtraitor_ is Ranger). This would still match PlaceFoe's foeSymbol from parsing a quest action (e.g. place foe _mtraitor_ at _wayrest_ marker 3). _mtraitor_ matches _mtraitor_. If they differed somehow then I think something would be seriously wrong.
Both PlaceNpc and PlaceItem use <QuestResource>.Symbol member variable for AssignQuestResource() as well, leaving PlaceFoe the odd one out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marker indexes for the
PlaceNpcquest action are not properly serialized, causing quest npcs to be placed at a random marker when the action is loaded. This is quite obvious in the questLord K'avar Part III, where the Lord K'avar flat could be located at a incorrect marker, and the foe at the correct one, causing K'avar to seemingly teleport across the dungeon.Also edited
PlaceFoe'sAssignQuestResourcepattern to match that ofPlaceNpc'sAssignQuestResourcefor consistency.Fixes #2700