Skip to content

Revert ImageReader frameCount check #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TwelveEyes
Copy link
Contributor

@TwelveEyes TwelveEyes commented Jun 12, 2025

Removing the frameCount check made some custom inventory items with custom textures appear as material silver. Reverting the change fixes this bug.

@KABoissonneault
Copy link
Collaborator

@ajrb You removed the check in 358068a for the custom transportation. What was it trying to fix, and could we fix it in some other way?

@ajrb
Copy link
Collaborator

ajrb commented Jul 20, 2025

I can't remember the details, but I think it was preventing animated textures working for inventory items for that file type. Obviously it's had a negative effect I didn't intend. This was a change done to help support someone wanting to mod in different horse breeds - they asked me for help with it but they lost interest AFAIK.

Suggest we revert this change, it's certainly not used in any of my mods.

@KABoissonneault KABoissonneault merged commit 3fdf424 into Interkarma:master Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants