Skip to content

Null check ImageData for BlitCloakInterior #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TwelveEyes
Copy link
Contributor

Fixes the paperdoll throwing a null exception trying to blit a cloak interior for a custom item that goes into the cloak slot and doesn't count as one of the hard coded cloaks (Formal_cloak or Casual_cloak).

Addresses part of #2740.

@TwelveEyes TwelveEyes force-pushed the fix-null-blitcloakinterior branch from 5a332d5 to 50be47d Compare June 14, 2025 04:47
petchema
petchema previously approved these changes Jul 20, 2025
@KABoissonneault
Copy link
Collaborator

Maybe we could have put those null checks inside DrawTexture itself, to make sure all paths are covered

@TwelveEyes
Copy link
Contributor Author

Maybe we could have put those null checks inside DrawTexture itself, to make sure all paths are covered

Makes sense to me. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants