vcpkg install iccdev

[xsscx]

Pull Request Checklist

• Have you followed the guidelines in Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you built your Pull Request locally with the Build Instructions?
• Have you added or updated relevant tests?
• Have you added or updated relevant docs?

[Copilot]

Pull request overview

This pull request modernizes the RefIccMAX CMake configuration file by transforming it from a basic find module into a comprehensive CMake package configuration file. The changes enable better integration with modern CMake projects and vcpkg package management.

Key changes:

• Introduces modern IMPORTED targets (IccProfLib2, IccXML2, and their static variants) following current CMake best practices
• Adds comprehensive documentation and usage examples for both modern targets and legacy variables
• Implements proper library detection for both shared and static library variants, including debug builds
• Maintains full backward compatibility with existing projects using legacy variables (REFICCMAX_LIBRARIES, REFICCMAX_INCLUDE_DIRS)

[Copilot]

The IccXML2 library's INTERFACE_LINK_LIBRARIES is set to IccProfLib2 (line 166), but there's no check whether IccProfLib2 was found as a shared or static library. If IccProfLib2 is static and IccXML2 is shared, this could cause linking issues. Consider linking to the appropriate variant (IccProfLib2-static if IccXML2 is static, IccProfLib2 if shared) based on which library type was found.

Suggested change

	IMPORTED_LOCATION_DEBUG "${ICCXML2_LIBRARY_DEBUG}"
	)
	endif()
	if(TARGET IccProfLib2)
	set_target_properties(IccXML2 PROPERTIES
	INTERFACE_LINK_LIBRARIES IccProfLib2
	)
	IMPORTED_LOCATION_DEBUG "${ICC2XML_LIBRARY_DEBUG}"
	)
	endif()
	if(TARGET IccProfLib2)
	# Prefer linking against shared IccProfLib2 when available
	set_target_properties(IccXML2 PROPERTIES
	INTERFACE_LINK_LIBRARIES IccProfLib2
	)
	elseif(TARGET IccProfLib2-static)
	# Fallback: link against static IccProfLib2-static if only static is available
	set_target_properties(IccXML2 PROPERTIES
	INTERFACE_LINK_LIBRARIES IccProfLib2-static
	)

[xsscx]

Potential True Positive. Testing in Progress.

[Copilot]

The ICCPROFLIB2_LIBRARY is marked as SHARED IMPORTED (line 125), but there's no verification that the library is actually shared. The find_library command finds any library with the given name regardless of type. If a static library is found instead, this will cause a mismatch. Consider using UNKNOWN IMPORTED instead of SHARED IMPORTED and setting the IMPORTED_LINK_INTERFACE_LIBRARIES property appropriately, or verify the library type before creating the target.

Suggested change

	add_library(IccProfLib2 SHARED IMPORTED)
	add_library(IccProfLib2 UNKNOWN IMPORTED)

[xsscx]

Potential True Positive. Testing in Progress.

[Copilot]

The IccXML2 library is marked as SHARED IMPORTED (line 154), but there's no verification that the library is actually shared. The find_library command finds any library with the given name regardless of type. If a static library is found instead, this will cause a mismatch. Consider using UNKNOWN IMPORTED instead of SHARED IMPORTED, or verify the library type before creating the target.

Suggested change

	add_library(IccXML2 SHARED IMPORTED)
	add_library(IccXML2 UNKNOWN IMPORTED)

[xsscx]

Potential True Positive. Testing in Progress.

[Copilot]

The fallback find_path for REFICCMAX_INCLUDE_DIR (lines 54-57) will search system-wide paths, but it may find an incompatible version if RefIccMAX is installed system-wide. This could cause version mismatches. Consider adding a VERSION check or making the NO_DEFAULT_PATH behavior stricter to avoid mixing installation locations.

Suggested change

	# Fallback for system-wide installation
	find_path(REFICCMAX_INCLUDE_DIR
	NAMES @TARGET_LIB_ICCPROFLIB@/IccProfLibVer.h
	PATHS @CMAKE_INSTALL_FULL_INCLUDEDIR@/@TARGET_INCLUDE_FOLDER@
	# Fallback for system-wide installation (restricted to explicit paths)
	find_path(REFICCMAX_INCLUDE_DIR
	NAMES @TARGET_LIB_ICCPROFLIB@/IccProfLibVer.h
	PATHS @CMAKE_INSTALL_FULL_INCLUDEDIR@/@TARGET_INCLUDE_FOLDER@
	NO_DEFAULT_PATH

[xsscx]

Potential True Positive. Testing in Progress.

[Copilot]

The HANDLE_COMPONENTS option is specified in find_package_handle_standard_args (line 106), but there's no code to actually handle components. This will cause CMake to fail if users specify components like find_package(RefIccMAX COMPONENTS IccProfLib2). Either remove HANDLE_COMPONENTS or implement proper component handling by checking RefIccMAX_FIND_COMPONENTS and setting component-specific FOUND variables.

Suggested change

HANDLE_COMPONENTS

[xsscx]

Potential True Positive. Testing in Progress.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[xsscx]

Status

Modify Private static to Static but the scope is TBD.

│ 301      * Function: GetInstance() │
│ 306  -   * Private static function foo │
│ 302  +   * Static function foo

and.... Class Mods...

97     * Purpose: The Reflectance Observer Element │
│ 398     ***************************************************************************** │
│ 399     */ │
│ 400  -  class CIccMpeReflectanceObserver : public CIccMpeSpectralObserver │
│ 400  +  class ICCPROFLIB_API CIccMpeReflectanceObserver : public CIccMpeSpectralObserver │
│

[xsscx]

Status

Considering the issues present, the Libs install across all platforms as expected. The Tools are not ready.

vcpkg install iccdev will correctly install IccProfLib & IccXMLLib
vcpkg install iccdev[tools] is not ready due to Source Code needing Modification as indicated above.

[xsscx]

vcpkg compile errors

Sample

iccDumpProfile.cpp.obj : error LNK2001: unresolved external symbol "char const * const icMsgValidateWarning" (?icMsgValidateWarning@@3PEBDEB)
iccDumpProfile.cpp.obj : error LNK2001: unresolved external symbol "char const * const icMsgValidateNonCompliant" (?icMsgValidateNonCompliant@@3PEBDEB)
Tools\IccDumpProfile\iccDumpProfile.exe : fatal error LNK1120: 2 unresolved externals