[Peras #4] Add ObjectDiffusion and PerasCert diffusion (instance of ObjectDiffusion)
#1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbagrel1
changed the title
PerasCert diffusion (instace of ObjectDiffusion)PerasCert diffusion (instance of ObjectDiffusion)
tbagrel1
changed the title
PerasCert diffusion (instance of ObjectDiffusion)PerasCert diffusion (instance of ObjectDiffusion)
tbagrel1
force-pushed
the
main-pr/object-diffusion
branch
from
80d3c69 to
f88b3ae
Compare
tbagrel1
force-pushed
the
main-pr/weighted-chain-selec
branch
6 times, most recently
from
dca0315 to
d7c3c64
Compare
tbagrel1
force-pushed
the
main-pr/object-diffusion
branch
3 times, most recently
from
37a9f85 to
222f4be
Compare
tbagrel1
force-pushed
the
main-pr/weighted-chain-selec
branch
from
d7c3c64 to
f1158c0
Compare
Also use defaultMiniProtocolParameters instead of hardcoded value in unstable-diffusion-testlib to account for newly defined parameters in the new `ouroboros-network` version. Also integrate `NodeToNodeV_16`. Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
…eader,Writer}` API Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
…fusion Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
tbagrel1
force-pushed
the
main-pr/object-diffusion
branch
from
222f4be to
d47c331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the ObjectDiffusion mini-protocol, required for Peras (for certificates and votes diffusion). It also plugs the PerasCertDiffusion (instance of ObjectDiffusion) mini-protocol in the networking layer.
This PR depends on an updated version of
ouroboros-network, see IntersectMBO/ouroboros-network#5181Peras ObjectDiffusion Mini-protocol:
Ouroboros.Consensus.MiniProtocol.ObjectDiffusion{.Inbound,.Outbound}with implementations of the ObjectDiffusion protocol (quite similar/inspired from TX-submission, except that client = inbound, server = outbound)Ouroboros.Consensus.MiniProtocol.ObjectDiffusion.ObjectPool.APIdefiningObjectPool{Reader,Writer}interfaces, through which ObjectDiffusion accesses/stores the objects to send/that have been received.Ouroboros.Consensus.MiniProtocol.ObjectDiffusion.PerasCertandOuroboros.Consensus.MiniProtocol.ObjectDiffusion.ObjectPool.PerasCertcontaining definitions specific toPerasCertdiffusion through the ObjectDiffusion mini-protocolOuroboros.Consensus.Node.Serialisationto add CBOR serialisation (SerialiseNodeToNode) forPoint blk,Tip blk, andPerasCert blkOuroboros.Consensus{.Node,.Node.Tracer,.Network.NodeToNode}to wire-in PerasCertDiffusion similarly to other mini-protocols (e.g. TX-submission)Tests and benchmarks
Added module
Test.Consensus.MiniProtocol.ObjectDiffusion.Smokewith smoke test for the general ObjectDiffusion mini-protocol (using mock objects)Added module
Test.Consensus.MiniProtocol.ObjectDiffusion.PerasCert.Smokewith smoke test specific toPerasCertdiffusion through ObjectDiffusionUpdates
Test.ThreadNet.Networkinunstable-diffusion-testlibaccordingly to the changes made inOuroboros.Consensus.Network.NodeToNodeNetwork Protocol Version Updates:
ouroboros-networkrev8dfff7b8916f7a56b2a3773438d5e5530c780710(c.f. [WIP] Add ObjectDiffusion miniprotocol for Peras cert and vote diffusion ouroboros-network#5181) through source-repository-package directiveouroboros-consensusforNodeToNodeV_16