Keep track of currency/token lengths in builtin Value #7349
+112
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliu41
requested review from
Unisay,
kwxm,
effectfully,
ana-pantilie and
a team
|
effectfully
approved these changes
Sep 19, 2025
| . fromInteger | ||
| . uncurry (*) | ||
| . (toInteger . Value.totalSize &&& toInteger . (+1) . Value.maxKeyLength) | ||
| . unValueTotalSize |
There was a problem hiding this comment.
Nit: at this point I'd just use a where or a let.
| -- | Like `pack` but does not normalize. | ||
| pack' :: NestedMap -> Value | ||
| pack' (normalize -> v) = Value v sizes size | ||
| pack' (normalize -> v) = Value v sizes lens size |
There was a problem hiding this comment.
The comment says it doesn't normalize, but it does normalize.
| ( IntMap.alter (maybe (Just 1) (Just . (+ 1))) (Map.size inner) ss | ||
| , IntMap.unionWith | ||
| (+) | ||
| (IntMap.alter (maybe (Just 1) (Just . (+ 1))) (B.length currency) ls) |
There was a problem hiding this comment.
This IntMap.alter <...> pattern occurs a lot, give it a general name like incOne or whatever (and use that instead of incLen)?
zliu41
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory usage of Values are updated to include a factor of max key length in the Value.