Skip to content

Added EntityPortalListener#1073

Merged
PeachesMLG merged 5 commits intomasterfrom
entity-portal-fix
Apr 5, 2026
Merged

Added EntityPortalListener#1073
PeachesMLG merged 5 commits intomasterfrom
entity-portal-fix

Conversation

@sh0inx
Copy link
Copy Markdown
Contributor

@sh0inx sh0inx commented Jan 6, 2026

  • rewrote PlayerPortalListener to be legible, because holy fuck it needed it
  • these two classes are pretty much identical now, if there's an issue with one, there's an issue with both
  • noticed that skyblock end -> overworld sends you to the spawn of the overworld instead of the island... not sure why (happens on release build)

sh0inx added 2 commits January 6, 2026 14:13
- rewrote PlayerPortalListener to be legible, because holy fuck it needed it
- these two classes are pretty much identical now, if there's an issue with one, there's an issue with both
- noticed that skyblock end -> overworld sends you to the spawn of the overworld instead of the island... not sure why (happens on release build)
Copy link
Copy Markdown
Member

@PeachesMLG PeachesMLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two classes are pretty much identical now, if there's an issue with one, there's an issue with both

Are they pretty much identical, or are they identical?

If they are identical we should de-duplicate this. They probabbly have a common portal event class.

I remember doing something similar in one of the events and you can basically just do

public void onEntityPortal(event){
   handle(event)
}


public void onPlayerPortal(event){
   handle(event)
}

void handle(PortalEvent event){ 
}

@sh0inx
Copy link
Copy Markdown
Contributor Author

sh0inx commented Jan 6, 2026

these two classes are pretty much identical now, if there's an issue with one, there's an issue with both

Are they pretty much identical, or are they identical?

EntityPortalEvent does not have a TeleportCause, so it looks for whether the entity is standing in an END_PORTAL and works through the logic appropriately.

@PeachesMLG PeachesMLG merged commit ac747fa into master Apr 5, 2026
1 check passed
@PeachesMLG PeachesMLG deleted the entity-portal-fix branch April 5, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants