Merged
Conversation
Contributor
sh0inx
commented
Jan 6, 2026
- rewrote PlayerPortalListener to be legible, because holy fuck it needed it
- these two classes are pretty much identical now, if there's an issue with one, there's an issue with both
- noticed that skyblock end -> overworld sends you to the spawn of the overworld instead of the island... not sure why (happens on release build)
- rewrote PlayerPortalListener to be legible, because holy fuck it needed it - these two classes are pretty much identical now, if there's an issue with one, there's an issue with both - noticed that skyblock end -> overworld sends you to the spawn of the overworld instead of the island... not sure why (happens on release build)
PeachesMLG
reviewed
Jan 6, 2026
Member
There was a problem hiding this comment.
these two classes are pretty much identical now, if there's an issue with one, there's an issue with both
Are they pretty much identical, or are they identical?
If they are identical we should de-duplicate this. They probabbly have a common portal event class.
I remember doing something similar in one of the events and you can basically just do
public void onEntityPortal(event){
handle(event)
}
public void onPlayerPortal(event){
handle(event)
}
void handle(PortalEvent event){
}
PeachesMLG
reviewed
Jan 6, 2026
src/main/java/com/iridium/iridiumskyblock/listeners/PlayerPortalListener.java
Outdated
Show resolved
Hide resolved
PeachesMLG
reviewed
Jan 6, 2026
src/main/java/com/iridium/iridiumskyblock/listeners/PlayerPortalListener.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.