Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waterway coverage #13

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix waterway coverage #13

merged 2 commits into from
Jan 23, 2025

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Jan 23, 2025

Waterway was not well added as it used the waterway type instead of the name...

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.08%. Comparing base (3bc7813) to head (09996d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a/il/org/osm/israelhiking/PlanetSearchProfile.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #13      +/-   ##
============================================
+ Coverage     82.95%   89.08%   +6.13%     
- Complexity      149      153       +4     
============================================
  Files             8        8              
  Lines           522      522              
  Branches         86       86              
============================================
+ Hits            433      465      +32     
+ Misses           72       39      -33     
- Partials         17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 3486943 into main Jan 23, 2025
3 of 4 checks passed
@HarelM HarelM deleted the fix-waterways branch January 23, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant