Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relation tags handling #14

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Fix relation tags handling #14

merged 3 commits into from
Jan 25, 2025

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Jan 24, 2025

This moves all the logic of tags to icon handling to one place and reduce the duplication that was there from previous code.
Hopefully, this will make the coverage happy.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.81%. Comparing base (c991735) to head (a2e288e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a/il/org/osm/israelhiking/PlanetSearchProfile.java 66.66% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #14      +/-   ##
============================================
+ Coverage     89.08%   91.81%   +2.73%     
+ Complexity      153      149       -4     
============================================
  Files             8        8              
  Lines           522      501      -21     
  Branches         86       79       -7     
============================================
- Hits            465      460       -5     
+ Misses           39       23      -16     
  Partials         18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit d6b7f63 into main Jan 25, 2025
3 of 4 checks passed
@HarelM HarelM deleted the fix-relation-tags-handling branch January 25, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant