Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flag --history-only to "hq journal stream" #841

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Adds flag --history-only to "hq journal stream" #841

merged 2 commits into from
Mar 10, 2025

Conversation

spirali
Copy link
Collaborator

@spirali spirali commented Mar 7, 2025

Streaming only past events from a live server without waiting for new ones.

@spirali spirali mentioned this pull request Mar 7, 2025
Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would modify the CLI so that we have:

  • replay - only streams the history
  • stream - only streams new events
  • stream --from-start - streams both history and new events (--from-start is bikesheddable)

Otherwise looks fine.

@spirali
Copy link
Collaborator Author

spirali commented Mar 8, 2025

I am not sure how much just live stream without history is useful. But I like the name "replay" for history-only command.

@Kobzol
Copy link
Collaborator

Kobzol commented Mar 8, 2025

Ok, no problem with just having replay and stream.

@spirali spirali merged commit 86d2e15 into main Mar 10, 2025
9 checks passed
@spirali spirali deleted the stream-stop branch March 10, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants