Skip to content

Fix resources & priorities when tasks are submitted in several submits with delay. #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

spirali
Copy link
Collaborator

@spirali spirali commented Mar 19, 2025

This is the next attempt to fix #848 .

@spirali spirali requested a review from Kobzol March 19, 2025 10:18
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem like they could be a bit flaky, it's better to use wait_until rather than sleeps.

@spirali
Copy link
Collaborator Author

spirali commented Mar 19, 2025

I have added some additional tests and they triggered the same assert as in #853. It is fixed now.

For the record: The bug is actually relatively old, the first fix of #848 did not introduce it, just expose it.

@spirali spirali merged commit 73e4f89 into main Mar 19, 2025
9 checks passed
@spirali spirali deleted the fix-848-2 branch March 19, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduling lower priority tasks when they wouldn't block any higher one
2 participants