Skip to content

Conversation

@j-horner
Copy link
Contributor

@j-horner j-horner commented Jun 9, 2021

Similiar to that in 92059a6

@Razish
Copy link
Member

Razish commented Sep 23, 2023

Can this be rebased on top of master for the automated builds to run? I'm suspect of this working on MSVC.
If it works fine, it's a 👍 from me

Copy link

@bartrpe bartrpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Razish it actually builds on MSVC, I just tested on whatever is the newest MSVC version built into Visual Studio Enterprise 2022

@SomaZ SomaZ requested a review from a team as a code owner May 20, 2025 19:19
Copy link
Contributor

@Daggolin Daggolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check seems to be correct, but does this actually occur? Multiplayer doesn't allow for non-glm NPCs. And if I remember correctly all glm NPCs should pass through SetupGameGhoul2Model, which should ERR_DROP on invalid localAnimIndex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants