Use a SOURCE ecbuild_bundle reference so that forks can be tested with JEDI-CI#28
Open
Use a SOURCE ecbuild_bundle reference so that forks can be tested with JEDI-CI#28
Conversation
srherbener
reviewed
Sep 16, 2025
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
I think this all looks good. I have a couple questions:
- This is being tested with the ioda draft PR: https://github.com/JCSDA-internal/ioda/pull/1507, correct? And it looks like this test is working.
- The idea behind this is to copy the contributed code (feature branches from a clone or fork) into a local area and then access the copied code via the ecbuild_bundle keyword "SOURCE". This works for direct clones as well as forks. Is this correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for the testing of forks since the GitHub action will use repository-scoped credentials to clone the target repo (avoiding the tricky situation of configuring multi-repo access for credentials)
Checklist