Clean up compiler flag specification#1227
Merged
Conversation
shlyaeva
reviewed
Mar 26, 2026
Collaborator
shlyaeva
left a comment
There was a problem hiding this comment.
Thank you for fixing soca @fmahebert! I did not review CMakeLists changes (not an expert), but the code changes and reference changes look good to me.
ytremolet
approved these changes
Mar 26, 2026
Contributor
@shlyaeva Can you approve the PR? |
shlyaeva
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a first step towards cleaning JEDI's specification of compilers flags, this PR reorganizes and changes flags as follows:
cmake/build_type_compiler_flags.cmakeprovides default build-type compiler flags for compilers not in ecbuild; this could eventually be contributed upstream. This file should be identical in all JEDI repos.cmake/jedi_common_compiler_flags.cmakeprovides JEDI specific compiler flags; for example warning levels, floating-point behavior, etc. This file should be identical in all JEDI repos.This has been tested with gcc13, IntelLLVM 2025.3, Intel mixing
icxwith legacyifort; and also with Cray by David Davies at UKMO. In general, for these compilers, the cleaned up flags have fewer runtime floating-point issues, and more compile-time warnings.Issue(s) addressed
This is work towards https://github.com/JCSDA-internal/CI/issues/173
Dependencies
Part of a large family of PRs, see the CI issue for a complete list. These do not strictly depend on each other.
Impact
Impact on users:
Checklist