Skip to content

New geoval file with air_temperature_at_2m variable#509

Open
rajichidamb wants to merge 21 commits intodevelopfrom
feature/GSLSurfaceOperator
Open

New geoval file with air_temperature_at_2m variable#509
rajichidamb wants to merge 21 commits intodevelopfrom
feature/GSLSurfaceOperator

Conversation

@rajichidamb
Copy link
Contributor

@rajichidamb rajichidamb commented Sep 29, 2025

Description

New geoval file with air_temperature_at_2m variable to be used for ctest in surface temperature correction with GSL mode.

jedi-ci-test-select=gcc

build-group=https://github.com/JCSDA-internal/ufo/pull/3622

Issue(s) addressed

Resolves #<issue_number>

Dependencies

List the other PRs that this PR is dependent on:

Impact

Expected impact on downstream repositories:

Manual Testing Instructions (optional)

If you would like your reviewers to manually build and test the change, please include
instructions on how the change should be built and tested. Also include a short
justification on why manual testing is necessary for this change.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

Copy link
Collaborator

@fcvdb fcvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raji!

Copy link
Collaborator

@fcvdb fcvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raji!

@HuiLiu-NOAA
Copy link
Contributor

@spanNOAA : could you take a look at this? Thanks.

@spanNOAA
Copy link

spanNOAA commented Oct 7, 2025

@spanNOAA : could you take a look at this? Thanks.

Yes, I'm trying to use this for ctest.

@huishao-r
Copy link
Collaborator

@spanNOAA @HuiLiu-NOAA Is this data ok for the testing purpose? https://github.com/JCSDA-internal/ufo/pull/3622

@fcvdb fcvdb added the OBS OBS processing, UFO label Jan 6, 2026
@BenjaminRuston BenjaminRuston added coordinate merge Ready for merge but needs to be coordinated with other repos needs review Asking others to review - often used for pull requests labels Feb 25, 2026
@BenjaminRuston BenjaminRuston removed the needs review Asking others to review - often used for pull requests label Mar 10, 2026
@BenjaminRuston
Copy link
Collaborator

@fcvdb why is this file changed?
testinput_tier_1/surface_tquv_geovals_gsl_2022052700.nc4

I'm seeing only this file being used:
surface_tquv_geovals_2025090100.nc4

and all of these as far as I can tell can be removed:

surface_tquv_geovals_2022052700.nc4
surface_tquv_geovals_2700_0000_geopotentialH.nc4
surface_tquv_geovals_gsl_2022052700.nc4

@rajichidamb
Copy link
Contributor Author

surface_tquv_geovals_gsl_2022052700.nc4 _ I added this file with air_temperature_at_2m variable. Since @fcvdb has new files, these probably can be deleted. surface_tquv_geovals_2022052700.nc4 is the previously used file for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coordinate merge Ready for merge but needs to be coordinated with other repos OBS OBS processing, UFO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants