Add diagnostic diff reporting in regression tests + remove ifort array temporary warning#274
Draft
BenjaminTJohnson wants to merge 7 commits intodevelopfrom
Draft
Conversation
…different messages.
…arning (406): fort: (1): In call to FITCOEFF_3D_CREATE, an array temporary was created for argument #2
chengdang
reviewed
Jan 7, 2026
Contributor
chengdang
left a comment
There was a problem hiding this comment.
All ctest passed.
Just to make sure I understand it correctly, this bug is raised when optical depth is very large. By "clamping" the exp (-OD), we can constrain this issue. Is this correct?
Is Compare_Diagnostics.inc a brand new module for CRTM? This is super thorough and useful!
| @@ -1853,9 +1919,13 @@ SUBROUTINE CRTM_ADA_AD(n_Layers, & ! Input number of atmospheric layers | |||
|
|
|||
| ! | |||
| IF( RTV%Solar_Flag_true ) THEN | |||
Contributor
There was a problem hiding this comment.
Hi Ben, I'm trying to understand this set up. With such if statement, if the total AOD is too big (is_clamped), then the total_opt_AD is not updated?
Contributor
Author
|
@chengdang this PR is partially impacted by the other big one #277, so after we merge 277, I'll come back to this one. Switching to draft. I'll also review your questions at that time. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch extends regression tests to report min/max/relative difference statistics across key CRTM structures, improving diagnostics when comparisons fail. It also removes Intel Fortran debug warnings about array
temporaries created when allocating FitCoeff objects.
Changes vs develop
FitCoeff_SetValueby storingSHAPE(C)in a localdimensionsarray before callingFitCoeff_Create.Testing