Open
Conversation
BenjaminTJohnson
changed the title
chengdang
approved these changes
Jan 15, 2026
Contributor
chengdang
left a comment
chengdang
left a comment
There was a problem hiding this comment.
These new tests are working as expected!
Start 193: test_FD_consistency_atms_n21
190/196 Test #193: test_FD_consistency_atms_n21 ..................... Passed 0.39 sec
Start 194: test_AD_consistency_atms_n21
191/196 Test #194: test_AD_consistency_atms_n21 ..................... Passed 0.02 sec
Start 195: test_FD_consistency_cris-fsr_n21
192/196 Test #195: test_FD_consistency_cris-fsr_n21 ................. Passed 0.26 sec
Start 196: test_AD_consistency_cris-fsr_n21
I only have a couple of minor questions on the tolerance value, otherwise I think this is ready to merge.
| RTSolution(l,PROFILE_IDX)%Radiance | ||
| tl = RTSolution_TL(l,PROFILE_IDX)%Radiance | ||
| diff = ABS(fd - tl) | ||
| tol = ATOL + RTOL * MAX(ABS(fd), ABS(tl)) |
Contributor
There was a problem hiding this comment.
Do we know why is this tol defined this way?
| INTEGER :: arg_count | ||
| REAL(fp) :: fd, tl, diff, tol, max_diff | ||
| REAL(fp) :: lhs, rhs, rel | ||
| REAL(fp), PARAMETER :: AD_RTOL = 1.0e-3_fp |
Contributor
There was a problem hiding this comment.
Same here, I'm sure there are some scientific basics for setting up these, could be empirical?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new finite‑difference consistency test to the ctest suite and wired it to run TL‑FD and TL‑AD checks. The test prints per‑channel deltas, uses the existing in‑code profile/surface data (no extra binaries), and is enabled for atms_n21 and cris-fsr_n21.
v.abi_g19 is included only if its coeffs are present.